Alberto Cantú Gómez

Results 106 comments of Alberto Cantú Gómez

Just as a reference here's what I accomplished with this https://ember-eui.netlify.app/docs/core/docs/display/avatar Select any demo and open template or component tab, you'll see a codesandbox link at the bottom

One question: it's ok the `tryContent` approach? which looks for the obj to notify, via hardcoded .content and ._content paths, basically notifying changests and proxy alike objects?

@snewcomer Dug a little bit more on this today to try to fix the tests and found out a few things... 1. `addObserver` works for deep keys, i.e: you can...

I'm using this with ember-m3, MegamorphicModels and seems to work great too

OK, so dug a lot more today, ObjectTreeNode proxies return different references between proxy access if the prop doesn't exists inside `node.content` here: https://github.com/validated-changeset/validated-changeset/blob/d9e54bea45d0ea88d4de7e9faf39733c050c755b/src/utils/object-tree-node.ts#L39 And so we can't realiaby notify,...

Had to bump node because one dep needs >=12 now? it prompted because of me using `volta`, which was pin to node@10~ ```ts error [email protected]: The engine "node" is incompatible...

I noticed assigning curr=path[i] was triggering `set` on the proxy, causing trouble to fix #585 But I think we can just traverse `"content"`, or hasOwnProperty on that content as suggested,...

Two more issues on my mind: 1. > Stumbled with another bug, when you try to changeset.get('super.deep.key') where content doesn't have such structure, it fails on this line because we...

thanks for the fix, it was so simple!, I thought some sorcery would be needed haha. > Just for some clarification, is the problem solely with addObserver? Or are there...

I was thinking in something like this in pseudocode: ```ts //ember-changeset new Proxy(obj, { get(target, path) { setDeep(target[MIRROR], path, true); .... continue default }, set(target, path, value) { setDeep(target[MIRROR], path,...