Bert Verhelst

> Try to avoid re-creating a table. fixed > And it looks like the `monitor_checks` table created 2 times. This was necessary since there is a foreign key that has...

> Start to test this feature, it looks like it breaks @chakflying's feature #173. fixed:  > And since `accepted_statuscodes` and `keyword` is being dropped, it could be a breaking...

> But we could keep them in `monitor.toJSON()` for backward-compatibility. fixed ``` // Deprecated: Use the values in the checks list instead accepted_statuscodes: JSON.parse(this.accepted_statuscodes_json), keyword: this.keyword, ```

> What do you think if the list renamed like this? Yeah that is good. I would use TEXT instead of HTML though. Since you can use it for text,...

> Doesn't work, `toJSON()` throws exception since those fields don't exist anymore. You'll have to get those values from your `checks`. Fixed > Also, I noticed that the default of...

> but now they do for some reason, causing the chart to have both overlapping Fixed 

> What do you think if the list renamed like this? I tried it, but it doesn't look all that good.  So i changed it with an extra dropdown...

> 1. (Bug) Change `Monitor Type` clear all checks unexpectedly I'm not sure what you expect to happen in this case? Checks only make sense for the http type. The...

@louislam > As this PR is very big, there are actually so many test cases. Do you write all test cases yourself for all PR's? Are they cypress tests? I'd...

> Instead of having `Should > equal (JSON selector)` it could be easier to use and to configure/code/validate to split this into three parts instead of two and have `JSON...