Robert Sachunsky
Robert Sachunsky
> TBH, I just never encounter the use case of passing a HTTP URL to a METS file directly to any of the CLI that accept `--mets` nowadays, This is...
What I am saying is: if you did have `RGB` samples, then the model should at least be advertised as `L`, not `1`.
Let me put it this way: As a user, I have no way of knowing that, there's only `one_channel_mode` in the metadata. And for your default `--spec` … https://github.com/mittagessen/kraken/blob/b48145dad2de326af0c1d3c837d0f823d2331412/kraken/lib/default_specs.py#L20 …...
> It will be set to `L` because the `im_mode` on the dataset object is set to the highest image mode _after_ applying the image transforms (which would produce grayscale...
> I don't know when he trained those models but in the past there was a bug where the mode wouldn't be upgraded because of the dataset running in separate...
> I can do that. Most of that stuff is stable but hasn't been documented as the correct image transforms get run automatically inside the respective methods. @mittagessen It's your...
> Apparently, I hadn't corrected the image mode promotion after all. There's a fix in `fix/8bit_mode_dataloader` which I need to verify and merge. I don't understand. So the documentation issue...
Yes, and an OcrdMods would also be needed if we were to extend #698 (automatic inheritance in OcrdPage hierarchy) with the document-wide lang/script features.
> Yes, and an OcrdMods would also be needed if we were to extend #698 (automatic inheritance in OcrdPage hierarchy) with the document-wide lang/script features. However, this could also be...
Valuable functionality that could be reused for OcrdMods can also be found in: - [ocrd_odem](https://pad.gwdg.de/DDgMpTwFQ9mOLnWdvajVgA) - [mets-mods2tei](https://github.com/slub/mets-mods2tei/tree/master/mets_mods2tei/api)