Robert Sachunsky

Results 941 comments of Robert Sachunsky

@kba > > (Perhaps at that time we got distracted by the fact that we still call `initLogging` unconditionally when importing `ocrd_utils.logging`.) > > Yes, the idea was to behave...

> Not logging anything, and if `initLogging` is not called, the initialization phase of the Operandi Server just freezes. I will try to unwrap: Operandi [on startup](https://github.com/subugoe/operandi/blob/6a71a04a26bda6dc8f1ef64d273058f8bba5cd89/src/server/operandi_server/server.py#L77) calls [ocrd_utils.initLogging](https://github.com/subugoe/operandi/blob/6a71a04a26bda6dc8f1ef64d273058f8bba5cd89/src/utils/operandi_utils/utils.py#L14-L30). So...

@kba @MehmedGIT in the last 6 commits, I rewrote the entire thing. I also made sure we have no side effects between tests anymore (which haunted me for quite a...

@MehmedGIT > Seems some adaptations are needed inside `ocrd_network` module as well. [Here](https://github.com/OCR-D/core/blob/master/src/ocrd_network/process_helpers.py#L31-L33) specifically. The processing job logs have many exceptions such as shown below. Just removing the `initLogging` call...

Can you try with [192895a](https://github.com/OCR-D/core/pull/1288/commits/192895afd5c38314e9a7de59b866b8bfedf1f523) again?

> The mets server's log file is not logging after the initialization though. What do you expect to see? Our logger is not used for anything beyond `DEBUG` level. And...

See [this recipe](https://github.com/fastapi/fastapi/issues/1508) for how we could include more messages from Uvicorn.

> I am expecting to see the `INFO` level logs of the [mets_server](https://github.com/OCR-D/core/blob/master/src/ocrd/mets_server.py). Are you perhaps still using a METS Server installation before [your extensive logging change](https://github.com/OCR-D/core/commit/e0ff4ebd3ea200a73b200375e75a4886eb1941fc)? (That would explain...

Oh my... confusion on all levels! > This is already merged it seems. No, it's not. You can clearly see a diff here. Also, it's not even **meant** to be...

Unfortunately, I'll have to add new changes to this PR, which will likely be needed on master as well: Since https://github.com/OCR-D/core/pull/1079, we must correctly distinguish between `local_filename` and `url`. If...