Robert Sachunsky

Results 944 comments of Robert Sachunsky

Perhaps we should also add some checks to ensure this never causes undetected problems again? For example, a simple `RUN ocrd resmgr list-installed` would have sufficed for this, but we...

> Today I tried to pull `ocrd_all` on my local machine a few times and always ended up with `failed to register layer: max depth exceeded`. May it also be...

> For example, a simple `RUN ocrd resmgr list-installed` would have sufficed for this, done: [a0937b6](https://github.com/OCR-D/ocrd_all/pull/444/commits/a0937b60f0eba1e68a17d15ff617ca53c00b8d7a). (I manually cancelled the job to save us unnecessary credits.) > but we could...

@MehmedGIT @kba here's the current `docker history --no-trunc --format 'table {{.CreatedBy}}\t{{.Size}} ocrd/all:maximum`: ```csv CREATED BY SIZE CMD ["/bin/sh" "-c" "/bin/bash"] 0B VOLUME [/data] 0B RUN |7 BASE_IMAGE=ocrd/all:medium VCS_REF=56507f1 BUILD_DATE=2024-07-01T15:37:51Z OCRD_MODULES=cor-asv-ann...

> Some of the commands could be abstracted away in separate script/s and called with a single RUN command. I'm already in the middle of that change – coming up...

Note: ffefb8f was not possible with earlier versions of Docker. The original idea of using multiple `RUN` steps while still doing the actual build in one stop (for minimal image...

So reducing the number of steps actually [brought down build time](https://app.circleci.com/pipelines/github/OCR-D/ocrd_all/1090/workflows/c813e23d-4ea3-4485-926c-6ac39a23a5d4) by 4min. How about trying to reactivate our parallel build again? Also, in the same experiment: let's try storing...

> Please also consider the cases in which the build is broken with an interruption. Rerunning the build should remove the files used for the parallel build. I remember facing...

Oh that! Yes, that can happen. Not sure how to fix this (I guess it's really a GNU parallel issue). But this should _not_ affect CI/CD, since this will spawn...

Oops! Seems we **do** have a [test failure](https://app.circleci.com/pipelines/github/OCR-D/ocrd_all/1091/workflows/5eb6cea7-e647-4a97-8b59-2e3144872fc3/jobs/1502?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary) when running `make test` in core (in the newly built Docker image). So ocrd_network complains that it cannot import `MpxReq` from `ocrd.mets_server`....