Robert Sachunsky
Robert Sachunsky
I don't know how, but some of these failed tests (like bashlib processor) must already have been failing earlier. Others might not have surfaced (test_processor had side effects because it...
> [mikegerber](https://github.com/mikegerber) [force-pushed](https://github.com/qurator-spk/dinglehopper/compare/a33b713f36bf4b592a7a5ba3fce187d67cdde274..7a79bae6fd98d7497443c17e691df29493e225da) the normalized-cer branch from [a33b713](https://github.com/qurator-spk/dinglehopper/commit/a33b713f36bf4b592a7a5ba3fce187d67cdde274) to [7a79bae](https://github.com/qurator-spk/dinglehopper/commit/7a79bae6fd98d7497443c17e691df29493e225da) [5 hours ago](https://github.com/qurator-spk/dinglehopper/pull/129#event-17301441364) Speaking about Github etiquette and collaboration best practices: force-pushing on someone's forked PR is really bad practice!...
Should be fixed since #119.
> * GitHub, (currently) free I recommend this for now. It's fairly [easy to setup](https://github.com/slub/ocrd_manager/blob/main/.github/workflows/publish.yml) on Github Actions and has a nice UI integration (_packages_ on the right, replacing Dockerhub,...
Also just [picked](https://www.docker.com/blog/no-longer-sunsetting-the-free-team-plan/) it up. That's good, and we got lucky this time, but IMO we should continue the new efforts at diversifying our deployment options. Does not harm to...
> To make this work, `ocrd resmgr` CLI should have an additional option `--ocrd-all-tool` I recommend against an additional option, since this will complicate matters for the user. Why not...
Indeed. In Pythonic core, we use `workspace.mets.add_agent` during `Processor.run_processor`. In Bashlib, we could add a new subcommand `ocrd bashlib add-agent -m mets.xml [other-params]`, and wrap that in some exported function...
> Exactly, but I would prefer an `ocrd workspace add-agent` subcommand for consistency. To be consistent with what exactly? In `ocrd bashlib` we already have `input-files [CLI-params]`. Consistency (to me)...
> I mean consistent with e.g. `ocrd workspace set-id`, i.e. have all the METS metadata functionality in `ocrd workspace`. ok, got it. But then we should also have `get-agent` etc....
What does the resmgr log say?