Jeremy Monat

Results 94 comments of Jeremy Monat

Yes, as I noted in the PR, it won't work until momath updates their documentation by putting out a new release. I made this a draft PR so we can...

@asmeurer I'm trying to find the docs preview. Didn't there used to be a link to it as one of the CI jobs? I see the job "ci/circleci: Build Docs...

@skirpichev helpfully pointed out that the artifacts tab of the "ci/circleci: Build Docs Preview" job Details link has links to the docs preview, so I previewed the docs by clicking...

Good news: The Documentation preview link appeared under the PR description. Bad news: It gives a 404 error > 📚 Documentation preview 📚: [https://rdkit--7219.org.readthedocs.build/en/7219/](https://rdkit--7219.org.readthedocs.build/en/7219/) The GitHub Action completed successfully: >...

@greglandrum Could you check for an error message on the Read the Docs project page or the like?

> It also doesn't look like RtD try to do a build based on this: https://readthedocs.org/projects/rdkit/builds/ The last successful build is [Passed version release_2019_03 (html)4 years, 9 months ago](https://readthedocs.org/projects/rdkit/builds/9060883/), which...

I misinterpreted your original comment, about using the RtD GitHub Action, as meaning that the RDKit docs are built using RtD. I believe we would need to get that set...

Similarly, are the RDKit C++ and Python builds for release created by CI? If not, that would also be a worthy goal, and probably a prerequisite for building the docs...

In their current state, the code blocks in that documentation page are not presented as code blocks, but as [run-on paragraphs](https://www.rdkit.org/docs/source/rdkit.Chem.Draw.html#rdkit.Chem.Draw.MolsMatrixToGridImage): I proposed using `>>>` because the code blocks displayed...

Thanks for researching that. I'll try using two colons, ideally after Documentation preview builds on CI #6849 is in place so I can check that I formatted the code blocks...