Jeremy Monat comments

Repositories
Issues
Comments

Results 94 comments of


                                            Jeremy Monat

Add MCS unit tests for stereochemistry

Nice job implementing tests. Perhaps include each parameter in FindMCS (say, the Boolean and Compare parameters) to catch any problems with other parameters in [FindMCS](https://www.rdkit.org/docs/source/rdkit.Chem.rdFMCS.html#rdkit.Chem.rdFMCS.FindMCS)?

docs(python): Add description and example of what happens when ignore_nulls=True on pl.concat_str

@DeflateAwning does this address the issue?

docs(python): Add description and example of what happens when ignore_nulls=True on pl.concat_str

Good catch; I wasn't thinking about the separator. I corrected the description. BTW, to pass the doctests, the code example output has to be correct.

docs(python): Add description and example of what happens when ignore_nulls=True on pl.concat_str

Request final review and, if approved, merging on this PR. It was endorsed by the original requestor. Thanks!