Bert De Block

Results 258 comments of Bert De Block

I was under the assumption that importing cjs from inside a type=module package was not an option. But I assume this might work by configuring package.json#exports? Would be better indeed.

Alright, would be much better indeed. Will update!

The classic build doesn't do this indeed. It seems [this bit](https://github.com/embroider-build/embroider/blob/main/packages/compat/src/v1-app.ts#L495-L497) is related? If you have any pointers, I can maybe try and fix it.

My simplified ember-try clone ([try-or-die](https://github.com/bertdeblock/try-or-die)) uses a "deep" merge/set approach. It doesn't deep-merge arrays though, but it is super flexible. It will work well for single-project repos, but in case...

I think we can tackle merging data into `package.json`, and overriding existing / adding new files, using the same new functionality. Instead of a `packageJson` key, we could introduce a...

I did a quick spike yesterday in try-or-die. Made a quick WIP PR if you are interested => https://github.com/bertdeblock/try-or-die/pull/1.

`if` check introduced [here](https://github.com/ember-cli/ember-cli/pull/10620) needs an extra condition it seems. Though, unsure if `res` being `undefined` is the actual bug.

Fixed in https://github.com/ember-cli/ember-cli/pull/10794.

https://github.com/http-party/node-http-proxy/pull/1666