ember-try icon indicating copy to clipboard operation
ember-try copied to clipboard

[INTERNAL] Move logic out of `ember-cli` commands

Open bertdeblock opened this issue 11 months ago • 5 comments

After this, we can easily:

  1. Migrate everything else (except ./lib/ember-cli-commands) to .mjs
  2. Update all our dependencies to latest because of 1.
  3. Introduce our own CLI to use ember-try without ember-cli

bertdeblock avatar Jan 29 '25 10:01 bertdeblock

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.15%. Comparing base (e0d196e) to head (bda3dce).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1063      +/-   ##
==========================================
- Coverage   95.54%   95.15%   -0.39%     
==========================================
  Files          21       18       -3     
  Lines         516      475      -41     
==========================================
- Hits          493      452      -41     
  Misses         23       23              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 29 '25 10:01 codecov[bot]

what would it look like to invert this? i.e. make this a type=module package with an index.cjs ? I'm only asking because we're changing most files across to mjs and it seems like that is wanting to be type=module 🤔

mansona avatar Jan 29 '25 10:01 mansona

I was under the assumption that importing cjs from inside a type=module package was not an option. But I assume this might work by configuring package.json#exports? Would be better indeed.

bertdeblock avatar Jan 29 '25 11:01 bertdeblock

yes you can configure package.json exports to point at a cjs file for the index 👍

mansona avatar Jan 29 '25 11:01 mansona

Alright, would be much better indeed. Will update!

bertdeblock avatar Jan 29 '25 12:01 bertdeblock