Bruce Robbins
Bruce Robbins
An update: On write, spark-acid does not write post-start-of-Gregorian calendar values correctly either: In Spark: ``` scala> val df = Seq(java.sql.Timestamp.valueOf("2017-03-14 23:22:01.786")).toDF("ts") df: org.apache.spark.sql.DataFrame = [ts: timestamp] scala> df.write.format("HiveAcid").option("table", "default.ts_acid2").mode("append").save()...
@SparksFyz > #34953 take a look this pr? If I understand that PR correctly (and I may not), it is related but orthogonal. One PR doesn't preclude the other. The...
cc @beliefer @cloud-fan
@beliefer > Please reference `SimplifyBinaryComparison`. Thanks, I will take a look. This is reference to the fall-through case, where we discover there is really only a single distinct group, correct?
> LGTM. Can you rebase to the latest master branch to retrigger github action jobs? Will do. I still have this as WIP because I don't understand the impact, if...
@cloud-fan I rebased and hopefully the tests will now run. Also I put [WIP] in the correct place in the title, which I will remove once I finished looking at...
> I still have this as WIP because I don't understand the impact, if any, of passing attributes created from the non-rewritten distinct aggregate expressions to the xxxAggregateExec constructor as...