Daniel Berrangé

Results 49 comments of Daniel Berrangé

Based on my interpretation of the output, I don't think the get_maintainer.pl script is the problem here. The CC list seems to be populated from 2 sources - Signed-off-by msgs...

FYI, the `opt/ovmf` namespace is reserved for QEMU to communicate with EDK2, which is why libvirt is reporting `That firmware name is reserved` for the `` config. Furthermore, the `X-`...

I'm not too fussed about that naming, if we have the checkbox as that'll do the job well enough.

FYI, in pull request #23 I implemented support for directly detecting & parsing swtpm's debug logs as a new data input format. I just skip over the swtpm control commands...

> The [libvirt-go-xml-module](https://gitlab.com/libvirt/libvirt-go-xml-module) (or libvirtxml for short) provides 100% coverage to Libvirt XML schemas. And this is validated by testing that the libvirtxml structs can losslessly roundtrip xml -> obj...

> Taking a single example, the [domain_x86_64](https://github.com/kubevirt/kubevirt/blob/main/pkg/virt-launcher/virtwrap/converter/testdata/domain_x86_64.xml.tmpl), libvirtxml is 19% bigger, that is, libvirtxml uses 119KiB compared to schema.go's 93KiB. Looking at the size of these in isolation gives an...

> @berrange I believe the idea is that this data is frequently sent back and forth between the various KubeVirt / Kubernetes components, so the additional traffic could be problematic....

> First up - sorry for the late reply and thank you for contributing! > > Ah, parsing logs. This will surely bite me in the ass, but I'm willing...

> [swtpm.log](https://github.com/user-attachments/files/16671110/swtpm.log) > > For your convenience, this is running the tpm2-tss test suite against swtpm. Parsing still breaks at some point, but that might very well be another tpmstream...

> I did find our other unrelated bug when I added tests, which I've fixed in a separate commit in the new set of patches. Oh nevermind, I see you...