git-publish
git-publish copied to clipboard
stefanha
After using 'c' command to edit CC list, it then re-adds people to the CC list regardless.
I'm trying to test a pull request email sending so I run with my own to address:
$ GNUPGHOME=/run/media/berrange/SecureDiskB1/gpg/ git publish --pull-request --to='[email protected]'
Stopping so you can inspect the patch emails:
cd /tmp/tmp148iop9k
[PULL 0/6] Qio next patches
(mbox) Adding cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <[email protected]> from line 'From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <[email protected]>'
[PULL 1/6] qio: rename qio_task_thread_result
(mbox) Adding cc: Peter Xu <[email protected]> from line 'From: Peter Xu <[email protected]>'
(body) Adding cc: Peter Xu <[email protected]> from line 'Signed-off-by: Peter Xu <[email protected]>'
(body) Adding cc: Daniel P. Berrangé <[email protected]> from line 'Signed-off-by: Daniel P. Berrangé <[email protected]>'
[PULL 2/6] qio: introduce qio_channel_add_watch_{full|source}
(mbox) Adding cc: Peter Xu <[email protected]> from line 'From: Peter Xu <[email protected]>'
(body) Adding cc: Peter Xu <[email protected]> from line 'Signed-off-by: Peter Xu <[email protected]>'
(body) Adding cc: Daniel P. Berrangé <[email protected]> from line 'Signed-off-by: Daniel P. Berrangé <[email protected]>'
[PULL 3/6] qio: store gsources for net listeners
(mbox) Adding cc: Peter Xu <[email protected]> from line 'From: Peter Xu <[email protected]>'
(body) Adding cc: Peter Xu <[email protected]> from line 'Signed-off-by: Peter Xu <[email protected]>'
(body) Adding cc: Daniel P. Berrangé <[email protected]> from line 'Signed-off-by: Daniel P. Berrangé <[email protected]>'
[PULL 4/6] qio: non-default context for threaded qtask
(mbox) Adding cc: Peter Xu <[email protected]> from line 'From: Peter Xu <[email protected]>'
(body) Adding cc: Peter Xu <[email protected]> from line 'Signed-off-by: Peter Xu <[email protected]>'
(body) Adding cc: Daniel P. Berrangé <[email protected]> from line 'Signed-off-by: Daniel P. Berrangé <[email protected]>'
[PULL 5/6] qio: non-default context for async conn
(mbox) Adding cc: Peter Xu <[email protected]> from line 'From: Peter Xu <[email protected]>'
(body) Adding cc: Peter Xu <[email protected]> from line 'Signed-off-by: Peter Xu <[email protected]>'
(body) Adding cc: Daniel P. Berrangé <[email protected]> from line 'Signed-off-by: Daniel P. Berrangé <[email protected]>'
[PULL 6/6] qio: non-default context for TLS handshake
(mbox) Adding cc: Peter Xu <[email protected]> from line 'From: Peter Xu <[email protected]>'
(body) Adding cc: Peter Xu <[email protected]> from line 'Signed-off-by: Peter Xu <[email protected]>'
(body) Adding cc: Daniel P. Berrangé <[email protected]> from line 'Signed-off-by: Daniel P. Berrangé <[email protected]>'
To: [email protected]
Cc: "Dr. David Alan Gilbert" <[email protected]>
"Daniel P. Berrangé" <[email protected]>
Paolo Bonzini <[email protected]>
Juan Quintela <[email protected]>
Eric Blake <[email protected]>
Peter Maydell <[email protected]>
"Marc-André Lureau" <[email protected]>
Gerd Hoffmann <[email protected]>
[email protected]
[email protected]
[c] Edit Cc list in editor (save after edit)
[t] Edit To list in editor (save after edit)
[e] Edit patches in editor
[p] Print final email headers (dry run)
[a] Send all
[q] Cancel (quit)
c
Now I definitely don't want to CC all those people when I'm testing this PR, so I selected the 'c' option, it opens the editor and I can delete all the CC addresses, but after saving and exiting the editor, it prints a message saying its adding a bunch of people to the CC list again ....
Stopping so you can inspect the patch emails:
cd /tmp/tmp148iop9k
[PULL 0/6] Qio next patches
(mbox) Adding cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <[email protected]> from line 'From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <[email protected]>'
[PULL 1/6] qio: rename qio_task_thread_result
(mbox) Adding cc: Peter Xu <[email protected]> from line 'From: Peter Xu <[email protected]>'
(body) Adding cc: Peter Xu <[email protected]> from line 'Signed-off-by: Peter Xu <[email protected]>'
(body) Adding cc: Daniel P. Berrangé <[email protected]> from line 'Signed-off-by: Daniel P. Berrangé <[email protected]>'
[PULL 2/6] qio: introduce qio_channel_add_watch_{full|source}
(mbox) Adding cc: Peter Xu <[email protected]> from line 'From: Peter Xu <[email protected]>'
(body) Adding cc: Peter Xu <[email protected]> from line 'Signed-off-by: Peter Xu <[email protected]>'
(body) Adding cc: Daniel P. Berrangé <[email protected]> from line 'Signed-off-by: Daniel P. Berrangé <[email protected]>'
[PULL 3/6] qio: store gsources for net listeners
(mbox) Adding cc: Peter Xu <[email protected]> from line 'From: Peter Xu <[email protected]>'
(body) Adding cc: Peter Xu <[email protected]> from line 'Signed-off-by: Peter Xu <[email protected]>'
(body) Adding cc: Daniel P. Berrangé <[email protected]> from line 'Signed-off-by: Daniel P. Berrangé <[email protected]>'
[PULL 4/6] qio: non-default context for threaded qtask
(mbox) Adding cc: Peter Xu <[email protected]> from line 'From: Peter Xu <[email protected]>'
(body) Adding cc: Peter Xu <[email protected]> from line 'Signed-off-by: Peter Xu <[email protected]>'
(body) Adding cc: Daniel P. Berrangé <[email protected]> from line 'Signed-off-by: Daniel P. Berrangé <[email protected]>'
[PULL 5/6] qio: non-default context for async conn
(mbox) Adding cc: Peter Xu <[email protected]> from line 'From: Peter Xu <[email protected]>'
(body) Adding cc: Peter Xu <[email protected]> from line 'Signed-off-by: Peter Xu <[email protected]>'
(body) Adding cc: Daniel P. Berrangé <[email protected]> from line 'Signed-off-by: Daniel P. Berrangé <[email protected]>'
[PULL 6/6] qio: non-default context for TLS handshake
(mbox) Adding cc: Peter Xu <[email protected]> from line 'From: Peter Xu <[email protected]>'
(body) Adding cc: Peter Xu <[email protected]> from line 'Signed-off-by: Peter Xu <[email protected]>'
(body) Adding cc: Daniel P. Berrangé <[email protected]> from line 'Signed-off-by: Daniel P. Berrangé <[email protected]>'
To: [email protected]
Cc: "Daniel P. Berrangé" <[email protected]>
[c] Edit Cc list in editor (save after edit)
[t] Edit To list in editor (save after edit)
[e] Edit patches in editor
[p] Print final email headers (dry run)
[a] Send all
[q] Cancel (quit)
It doesn't not appear to have actually re-added Peter Xu to the CC list, despite what its claiming here, so these messages are a bit misleading.
It seems the messages about re-adding Peter Xu were not misleading - it has in fact sent emails to him despite me removing him when editting the CC list, and it showing the overall CC list as
To: [email protected]
Cc: "Daniel P. Berrangé" <[email protected]>
If you are using the QEMU .gitpublish "default" profile then I suspect cccmd is interfering with your manual edits. Can you confirm that deleting "cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null" from QEMU's .gitpublish file fixes the issue?
If that's the case then I think we need to run cccmd once only.
Based on my interpretation of the output, I don't think the get_maintainer.pl script is the problem here.
The CC list seems to be populated from 2 sources
- Signed-off-by msgs in the commit message
- People from get_maintainer.pl
When I editted the CC list, I purged everyone, but it re-added only people in the Signed-off-by messages - it didn't readd people from get_maintainer.pl