Bernhard Owen Josephus

Results 361 comments of Bernhard Owen Josephus

This doesn't happen in prod because, in prod, you can't open the chat context menu while an emoji picker is visible. But this issue happens in prod if you open...

It happens after https://github.com/Expensify/App/pull/50974, yes, but it's an existing issue which I explained in my comment above.

> isPopoverRelatedToTooltipOpen tells whether the tooltip element contains/is the same as the visible/active popover anchor. It's to prevent the tooltip of a button that shows the popover from showing while...

We are not really storing the ref, but the ref value, that is the HTML element. `isPopoverRelatedToTooltipOpen` memo affects the rendering, so we need to re-calculate it when the anchor...

Here is a few examples https://github.com/Expensify/App/blob/186c1a976acbc65faf8b739e34bb0c7936fbd1f2/src/pages/NewChatSelectorPage.tsx#L19-L21 https://github.com/Expensify/App/blob/186c1a976acbc65faf8b739e34bb0c7936fbd1f2/src/pages/iou/request/IOURequestStartPage.tsx#L95-L97

Here is the test branch: https://github.com/bernhardoj/Expensify/tree/fix/51114-emoji-picker-won't-open

Edited by **proposal-police**: This proposal was **edited** at 2024-11-21 13:28:28 UTC. ## Proposal ### Please re-state the problem that we are trying to solve in this issue. RBR is not...

I'm not sure if we should show the RBR on the workspace chat. In this [PR](https://github.com/Expensify/App/pull/51893), they mention that the RBR should show on the workspace chat, but this [comment](https://github.com/Expensify/App/pull/51893#issuecomment-2468956992)...

Ok, I got it now. It's supposed to work but there is a small bug. Updated my proposal to fix that.