Bernd Porr

@lukasberbuer can you check out the branch copyconstructors and test if it works? There is now also a unit test. See comment there where I discuss it with @nickbailey. if...

Hi Antonio, thanks for flagging this up. Do you have a test case were this fails? Looks like that this code segment is never reached by any of the detectors...

That's great. Thanks!

We benchmarked the different detectors: https://www.biorxiv.org/content/10.1101/722397v3 the problem is that current "gold standard" is just an all/nothing within a time window which is usually chosen at 10% of the heartrate...

PS: the API also allows to add a local path to the ECG data. Added that in 1.0.3.

I've created a bugfix branch and worked in your fix. The library needs tons of unit tests anyway. Tempted to advertise it as an MSc project next year but if...

 Certainly correct that this causes a phase inversion and the fix is correct. @anleu confirmed that now with a unit test using scipy output. Also makes total sense as...

The wrapper around i2c is so thin in the wiring pi library that one could directly do i2c access via ioctrl. It's virtually not more code. I might have a...

The API is great as it is. I'd suggest to just fix the documentation and state that the function actually returns the real range not just zero on success. If...

Hi Antonio, that all looks good. Thanks for delving deeply into it. Actually the new visual code directly threw the original code as an error. I've also absorbed the if...