Berkus Decker comments

Results 207 comments of


                                            Berkus Decker

Recursive monitoring request

Agree with @akapelrud lets add some flag in the interface (or another method set like `add_directory_recursive()`) for the recursive case and make default non-recursive. Opinions?

helper::throw_system_error_if and helper::to_utf8 should be inline to avoid linking errors

Thanks, I will update the code asap.

Translate IN_ATTRIB to IN_MODIFY

Sorry guys, I was busy for a while but will get back and review the PRs. Is there anything changed here or the code seems good to go to you?

monitor_operation::PostAndWait prevents shutdown

Do you want to make a PR for this?

monitor_operation::PostAndWait prevents shutdown

async processing most probably needs more fixes.

monitor_operation::PostAndWait prevents shutdown

This is supposed to be fixed by PR #40 right?

jjconfig.toml should be opened recursively from the current dir

This is just similar to how git finds its `.git` directory and I think it makes some sense for the config file. I.e. I can have a directory for Work...

jjconfig.toml should be opened recursively from the current dir

> note that the Git-for-Windows devs [considered that a security vulnerability](https://github.com/git-for-windows/git/security/advisories/GHSA-vw2c-22j4-2fh2). Seems like a valid concern on systems where random users can write anywhere. Probably windows build should disallow searching...

`Running Futures` example is invalid

If you try to unwrap() and run block_on(handle.unwrap()) then riker will crash with: thread 'pool-thread-#0' panicked at 'cannot execute LocalPool executor from within another executor: EnterError', stack backtrace: thread 'pool-thread-#4'...

Question: can git-bug "branch" and "merge" (similar/same as regular git files/content)?

Just to confirm — current version of git-bug does NOT track bugs differently in different branches; and bug state is thus global to the repository?