Berkus Decker comments

Results 207 comments of


                                            Berkus Decker

Improve pch usage

* Use IWYU - makes better code * Put only system headers in the pch * cotire had problems with pch when using sub-directories targets, investigate if using only system...

Two dir_monitors on a single io_service

Hi, if you are novice with ASIO I recommend going through Boost.Asio examples and working with that library in particular. `dir_monitor` is a simple enough user of the existing ASIO...

Two dir_monitors on a single io_service

Adding some good examples is always good - I'll happily accept documentation PRs.

Consider changing namespace from boost::asio to anything else

I didn't invent this - this was done by Boris long time ago, I guess he was aiming to make it part of asio eventually (but why?). Any suggestions what...

How to shutdown the dir_monitor object in order to allow the io_service to exit the .run loop?

Hmm, I'm pretty sure you can just stop monitoring the directories and it should not add any work if it's not doing anything. I need to refresh my memory though,...

Removed unnecessary converting to utf8

Does it mean that `helper::to_utf8` is working incorrectly? The transformation should be reversible.

Removed unnecessary converting to utf8

Of course in case of modern Windows there shouldn't be any problem in using just std::wstring, as that's the primary string type (althought it's UTF-16 not plain UCS-2).

Removed unnecessary converting to utf8

Merged this to `develop`, keeping open for discussion though.

Removed unnecessary converting to utf8

So the previously invalid name is now handled properly by our utf16 conversion?

Removed unnecessary converting to utf8

Sorry guys, I was busy for a while but will get back and review the PRs. Is there anything changed here or the code seems good to go to you?