Berkay Şahin

Results 21 comments of Berkay Şahin

> I have a two questions: > > 1. Do you know of any examples of "algorithmic limitations" (e.g. plans where unnecessary columns are carried through)? > 2. How does...

If I remember correctly `LogicalPlan` rule works with qualified column names. Let's think there is a plan such as: _A

Yes, as you said, in short, the rule consists of tracking the required columns across the plan and rewriting the plans by new expressions with updated indices.

> Is it like FunctionalDependence in DFSchema ? I couldn't understand the way you think there is a similarity, can you give more detail?

> I believe this PR has been superceded by #10504 which removed the montonicity apu in favor of a more expressive bounds analysis, so closing this pR > > Thanks...

What comes to my mind is that if we can successfully bring the `statistics` to `SortPreservingMerge`, it could handle this work without a separate operator (This will probably need a...

> Is this PR ready to merge? We are thinking on more extendable and user friendly API. Giving schemas as an option can be a misuse, and in the future,...

This PR is now ready for review. By employing that [method](https://github.com/apache/datafusion/issues/10414#issuecomment-2099555237), users can choose to maintain the existing behavior if desired.

> Doesn't really matter to me how it works, though I find the mismatch somewhat surprising - but mainly I just wanted to flag this in case this was not...

`CreateExternalTable` has some CSV specific fields: /// Whether the CSV file contains a header pub has_header: bool, /// Delimiter for CSV pub delimiter: char, After the new way of setting...