Berkay Şahin

Results 21 comments of Berkay Şahin

> This PR: > > Removes RewriteRecursion, > Renames VisitRecursion to TreeNodeRecursion, > Modifies TreeNodeRewriter to incorporate an f_down and f_up methods and use TreeNodeRecursion These changes seem reasonable to...

> I'm not sure I get this part. The docstring you have updated for `transform()` states that the order is: ``` 1) f_down(ParentNode) 2) f_down(ChildNode1) 3) f_up(ChildNode1) 4) f_down(ChildNode2) 5)...

> This is correct. This is because the proposed new `transform()` does only one traversal. It is exactly the same order how the old and new `TreeNode::rewrite` / `TreeNodeRewriter` worked...

> API users can explicitly call `transform_up()` and then `transform_down()` (2 pass) if this is needed. Do you have a real use case for this? Since we set out to...

Thanks everyone. I will carefully review this PR after #8817 is merged and the related updates are done. Thank you again @peter-toth for your efforts!

I would like to review and collaborate on this PR. Could you please notify me when it is ready?

This issue will be resolved as well when I launch the new projection optimizer rule. You can see the details here https://github.com/apache/arrow-datafusion/issues/9111. If you have any question or suggestion, please...

> @ozankabak / @berkaysynnada is there a ticket somewhere that describes what you are doing ? We will open the PR to the upstream next week. I will also request...

> Just to be clear, I was suggesting a ticket **Before** the PR. Some reasons a ticket prior to PR might be be beneficial are: I thought it would be...

I am not sure this is what you searched for but there was an issue https://github.com/apache/arrow-datafusion/issues/5535. Actually, I have tried to apply cp_solver strategy to prune row groups. But we...