Roey Berman

Results 193 comments of Roey Berman

Note to self, this works: ```ts function payloadToJSON({ metadata, data }: Payload): JSONPayload { return { metadata: metadata && Object.fromEntries( Object.entries(metadata).map(([k, v]): [string, string] => [k, Buffer.from(v).toString('base64')]) ), data: data...

FTR the code is located here: https://github.com/temporalio/temporal/blob/bb507313febe5a2cb509f5aa46918d9587b086f4/common/rpc/rpc.go#L218. I'm not sure what other locations in the code would need to change to accept `passthrough:///` URLs. We won't prioritize this work in...

I cannot reproduce this (using the latest CLI - 1.4.0) but there are no known differences since 1.3.0. The current theory is that retention timers were triggered on the workflows...

Overall SGTM. I'd maybe just call the top level key `dynamic` because you're already in the context of `config` but that's mostly nitpicking.

Seems like this is working as intended by using an internal frontend role.

This PR could use some tests and there would be an example in the documentation showing how this may be used. I want to understand the experience you had in...

It was disabled during the gogoproto refactor. I noticed it in my last PR and reenabled it: https://github.com/temporalio/api-go/commit/5a9f0194fe2d73970eb0ae283b4e0c5292fe9e96.

Assuming this check does what I think it should be doing.

We are reworking all of the docker images at the moment and as part of that effort we are completely removing dockerize from the image. This should all be done...