Bjørn Erik Pedersen

Results 874 comments of Bjørn Erik Pedersen

@RalphCorderoy you can do like this: ``` {{ $fingerprinted := $css | fingerprint }}

>{{ with resources.Copy (printf "css/style.%d.min.css" (crypto.FNV32a .Content)) . }} Yea, that works, but you end up recalculating that same hash over and over again -- a common thing with these...

>Yeah, I guess partialCached only gets you most of the way there. Yea well, most of the way is good enough in this scenario, I guess. I have a fix...

>So, the resources.Copy approach fails if you PostProcess the resource prior to copying. Which I think makes sense, but makes my head hurt. Yea, that's definitively not supported with how...

@nick2432 this issue isn't very straight forward, so I would prefer to do this myself.

Sorry for the delay. I'm going to rebase/test/wrap this up in #13837 -- thanks!

>enableDefault = true We could possibly also make this an enum, e.g. `enableDefault = {never,always,fallback}` Or something (these tri-state values is also used in the "use resource cache" config; maybe...

>useEmbedded would be more accurate. I agree. Let's do that, but it needs to wait a few days until I land my very much related template branch.

I'm not totally sure about the method name. Since it should behave the same as the current `i18n` func, maybe we should just name it `site.I18n` so people don't get...

>Without a capitalized "I", I'd suggest: site.i18n. * As this would be a method on the `Site` interface, the Go spec forces first character to be uppercase for public/exported methods....