Björn Rabenstein
Björn Rabenstein
I still haven't found time for a detailed review. I will try later this week or early next week. My apologies.
About the lookback delta: There is even a test for it, see https://github.com/prometheus/prometheus/blob/806073ad6311bdccf0bc102a00fa7eda9fb563fb/promql/promqltest/testdata/staleness.test#L38-L51 Which means that the lookback is "inclusive" right now, but it needs to be "exclusive", so essentially,...
And yet another question: How to merge this? To merge this into main before the v3 release, we need to hide the behavior behind a feature flag. However, that doesn't...
WRT lookback delta: I think the one and only argument is the one made by @vpranckaitis already. "Correct" is whatever behavior we define as such. The implementation details in the...
About flags and configurability: I think it is uncontroversial that v3 should only support the new behavior (the one implemented in this PR), with no way of bringing back the...
I unresolved two conversation above where you went into the opposite direction than intended.
FTR: @machine424 I think this is a good example for a PR that is simple enough to just merge once you have approved
Looking at this during the bug scrub. Since this draft has been sitting untouched for a year, we'll close this now. @zenador this should not discourage you from further work....
Hello from the bug scrub! This looks like a duplicate of #9057 , where more discussion has already happened. Closing this to bundle the discussion over there.
Yes, you are right. Please review #12839. :)