Björn Rabenstein

Results 1096 comments of Björn Rabenstein

But that assumes that every alert has a threshold. However, that's not the case. And even if there is a threshold, the operator between the threshold and the remaining expression...

These reports should disappear with the next minor release of the Alertmanager (as we routinely upgrade dependencies for a minor release). However, if these CVEs are all in code that...

Dependencies are generally updated automatically. Therefore, each minor release should include all pending dependency updates. (And chances are that the dependencies your security scan has listed are already updated in...

I guess the implementation for all the other fields will follow the same pattern as #2534. PRs welcome. :smiley:

That would collide with any secret that happens to start with `file:` (unlikely, but who knows…). I guess including a "schema" from the beginning would have been the best solution...

I'm in no way an expert when it comes to the Prometheus evaluation engine, but I remember this discussion from long ago. I use to answer this as: "Yeah, that...

Nits addressed. I'll hold back merging this until https://github.com/prometheus/prometheus/pull/11447 is merged.

Note that https://github.com/prometheus/prometheus/issues/11277 proposes explicitly configurable bucket boundaries in a Native Histogram with a custom bucket layout. This could be used to perfectly emulate any conventional Histogram. However, that's more...

How about we require to add a no-op span (length zero) in this case? Those spans are legal, and will be compacted away, but we could use them as the...

Maybe we need the examples to use their own `go.mod`? But that might lead to weird situations… Or we can reconsider the `exclude` directive? IIRC it was only added to...