Björn Rabenstein

Results 1096 comments of Björn Rabenstein

Demoting to P2 because we decided in the sync meeting we are confident that things work correctly for now, so it's not a blocker for the merge into main (still...

Hmmm, our golangci-lint doesn't know Go1.19 yet. That's why we cannot get all test pass.

I'll just switch to Go1.18 then. Enough for generics.

I realized there is a bug in the code. Will fix ASAP. Stay tuned…

OK, it works now. Please review now. :o)

Review hint: The actually important differences are just in the `compactBuckets` function. The diff isn't displaying that well. I recommend to copy out the old and new version of the...

I think some confusion has happened here. This issue is about the new Native Histograms. Currently, all related code exclusively lives in a [branch](https://github.com/prometheus/prometheus/tree/sparsehistogram). The code in [main](https://github.com/prometheus/prometheus/tree/main) is only...

Yeah, no clue how to do the UI testing properly. The little bits of code I wrote for Native Histogram support were totally makeshift. @Nexucis any help would be very...

I think we can demote this to P2: - client_golang already works fine with the old protobuf format. - client_java has support for the old protobuf format in a feature...

I think the problem is that Prometheus alerts aren't just limited to comparing a metric to a threshold. Arbitrary PromQL expressions can be used as an alert, and that alert...