Ben Vinegar

Results 73 comments of Ben Vinegar

Could you give us examples of what kind of custom events you want to track? Or, if you're doing that already with another tool, what that looks like code-wise?

Yeah `counter.js` is a good idea. Fits the name, could even work as a branding element (e.g. people see `counter.js` in the network tab, more obvious what it is). Re:...

Thanks for coming back. This seems in the right ballpark. > By that, do you want everything to go through GET request and branch based on the content type? I...

Thanks for the PR. Sorry, I've been travelling for the past few weeks and haven't had an opportunity to review it. >Should I have made this on the v2 route?...

Going to merge this. As a follow on, IMO, the query should be both `>=` and `

I did rush this out pretty fast ... this is the most detailed feedback I've gotten yet. Super helpful, thanks @wesbos. 🙏

@BhanuNexus Does this address any particular functionality you observed? I'm all for updating packages, but I usually do so to serve some kind of purpose – e.g. to address a...

> [thought] it will be useful for clarity I agree. I'm happy to merge if you can address the failing ESLint errors. I'm guessing something about the package upgrades caused...