counterscale icon indicating copy to clipboard operation
counterscale copied to clipboard

Updated packages and env interface

Open BhanuKorthiwada opened this issue 1 year ago • 3 comments

BhanuKorthiwada avatar Aug 25 '24 07:08 BhanuKorthiwada

@BhanuNexus Does this address any particular functionality you observed?

I'm all for updating packages, but I usually do so to serve some kind of purpose – e.g. to address a security vulnerability, or because a method has been added that I need.

benvinegar avatar Aug 28 '24 16:08 benvinegar

Recent wrangler package has option rename Env to CloudfareEnv, taught it will be useful for clarity. Included in this commit, https://github.com/benvinegar/counterscale/pull/92/commits/ff885b9bc2c3a6d0ec14f6671d0110953c056035

Long with this package, I did minor upgrade to available packages. But I agree that this change alone doesn't add any value.

BhanuKorthiwada avatar Aug 28 '24 17:08 BhanuKorthiwada

[thought] it will be useful for clarity

I agree.

I'm happy to merge if you can address the failing ESLint errors. I'm guessing something about the package upgrades caused these errors to trigger, because it isn't happening on main.

Failures here: https://github.com/benvinegar/counterscale/actions/runs/10545026564/job/29214724461?pr=92

benvinegar avatar Sep 07 '24 13:09 benvinegar