Benjamin Sternthal
Benjamin Sternthal
I was able to get this to run by commenting out the following line: `link.html.location = node.__location.attrs[attrName];` https://github.com/stevenvachon/broken-link-checker/blob/master/lib/internal/scrapeHtml.js#L34 I did not find references to this attribute in the code, so...
Sooo, the above led me to find a mismatched a href in my code. Fixing that fixed this. This might be a scenario where node.__location.attrs returning undefined throws an error....
Here is an example snippet that will reproduce the error: https://gist.github.com/bensternthal/e186520f239909b0ba52e861d01bfaca The`` on line 11 is causing the issue.
No prob, glad I can help. The module is very handy, many thanks for creating & maintaining it.
Waiting on timing.
@pmac is this work no longer valid given https://github.com/mozmeao/infra/issues/1193
Since this is not a solved problem.. and I agree with you on heroku I will leave this one open. There is good background here that I think would be...
Whoops I did not see that earlier PR!
@SimenB I'd like to help draft this and create the PR. Do you know if Jest is planning to opt-in to manage CoC violation reports directly or will this fall...
@SimenB @rickhanlonii for visibility.