Minor bug and comments

[harvey-green]

Firstly thanks for putting up this repo, its really valuable! Just some minor issues I noticed ...

• It would be helpful to include a twiddlefactors.v file with sufficient comments so that its easy to get something going without having to install python to generate this file.
• The file generate_twiddlefactors.py has a syntax error (in Python 3.3) on the line for i in range(0, N/2):
• it should read: for i in range(0, int(N/2)):
• The width parameter to the make_twiddle_factor_file() function is undocumented - I don't know what its for or what I should set it to.
• The generate_twiddlefactors.py contains no mainline. Running it does nothing, you need to add a function call, such as this, at the bottom of the file to run it. make_twiddle_factor_file(64, 9, 'twiddlefactors_N.v.t', None)

Lastly sorry I didn't issue pull requests for these issues as I'm at work now and don't have git setup. However, I thought rather than not doing anything I'd at least submit this issue. Cheers, hgreen.

[benreynwar]

Thanks for submitting these issues. It's always nice to get constructive feedback.

On Tue, Jun 3, 2014 at 12:15 AM, hgreen [email protected] wrote:

Firstly thanks for putting up this repo, its really valuable! Just some minor issues I noticed ...

• It would be helpful to include a twiddlefactors.v file with sufficient comments so that its easy to get something going without having to install python to generate this file.
• The file generate_twiddlefactors.py has a syntax error (in Python 3.3) on the line for i in range(0, N/2):
• it should read: for i in range(0, int(N/2)):
• The width parameter to the make_twiddle_factor_file() function is undocumented - I don't know what its for or what I should set it to.
• The generate_twiddlefactors.py contains no mainline. Running it does nothing, you need to add a function call, such as this, at the bottom of the file to run it. make_twiddle_factor_file(64, 9, 'twiddlefactors_N.v.t', None)

Lastly sorry I didn't issue pull requests for these issues as I'm at work now and don't have git setup. However, I thought rather than not doing anything I'd at least submit this issue. Cheers, hgreen.

— Reply to this email directly or view it on GitHub https://github.com/benreynwar/fft-dit-fpga/issues/1.