Ben Radford
Ben Radford
I started looking into doing the copying with an external process as @aherrmann suggested (something like `tar -c -T files.list | tar -x -C $dest_dir`) but I don't have a...
I've created the above draft pull request with my `tar` solution but I'm not sure how much of an improvement it is since I don't have a Mac to test....
Ah that makes sense, thanks for looking into it further.
Thanks for checking this on Mac @lamcw. It's good to hear the performance improvement there is greater than on Linux. Though since it's about the same as your `stat` solution...
Going with #259 as a solution instead.
I started looking into this but it seems like `node_repositories` changed quite drastically between 4.4.6 and 5.5.3. It no longer takes `package_json` and `vendored_node` parameters. I don't really have the...
Closing as it's been nearly a year with no changes now. Feel free to re-open if this is something you're still interested in getting merged @ryanrasti.
@layus @avdv I think I [resolved](https://github.com/tweag/rules_nixpkgs/pull/240/commits/20ad84f8355a9b97e6dea89c1f8458adf8f3ce7d) the merge conflict between this PR and [Pass the unwrapped `cc` to `wrapCCWith`](https://github.com/tweag/rules_nixpkgs/commit/a8e29785b01f732491bb6ff16b5183210f6f83fa) appropriately, but let me know if I made a mistake.
@YorikSar are you able to check whether this issue still occurs after @evertedsphere's changes?
> why did you need to do any setting of LD_LIBRARY_PATH in your docker example? I'm not the original author of that change so this is a complete guess, but...