Ben Orozco comments

Results 91 comments of


                                            Ben Orozco

Not working on macOS

@mihaibogdan10 just released new minor, can you try to see if the issue is still happening?

Not working on macOS

> @benoror still does not work for MacOS how so?

Strip away arguments used by bnr?

do you mind sharing the `scripts` part of your `package.json` ?

Pagination: bind `itemsPerPage` in custom template

Plunker example: http://plnkr.co/edit/gSDBAx?p=preview

Pagination: bind `itemsPerPage` in custom template

Hi @michaelbromley, thanks for your response. Sounds like a viable way to support this, since it's such a small component. Nevertheless I keep wondering if wouldn't it be cleaner to...

Pagination: bind `itemsPerPage` in custom template

Please refer to https://github.com/michaelbromley/angularUtils/issues/212 for extra info and an example from ui-grid's implementation

Pagination: bind `itemsPerPage` in custom template

Hi! I would be glad to contribute, could you give me a clue about where to look at? Would this test be sufficient? ``` describe('pagination controls template API', function() {...

Pagination: pageChanged handler should accept `newPageSize` when working with Asynchronous Data

Looking at uigrid's code I found a clue for the way the watcher is written: https://github.com/angular-ui/ui-grid/blob/7420b4b54eba5798053b99d1c6c0dcc67c530080/src/features/pagination/js/pagination.js#L377

Pagination: pageChanged handler should accept `newPageSize` when working with Asynchronous Data

Ok this is how I implemented this on application level, aklthoug it would be nice to be incorporated into the directive: View: ``` records per page ``` Controller: ``` var...

Pagination: pageChanged handler should accept `newPageSize` when working with Asynchronous Data

**Updated** to avoid infinite loops in some scenarios: ``` var vm = this; // Default options vm.options = {}; vm.options.paginationPageSizes = [4, 8, 16, 32, 64, 128]; vm.options.totalItems = 100;...