Benoit Tigeot

Results 90 comments of Benoit Tigeot

I think the change on spec could be dismiss expect the proper syntaxe. I will work on https://github.com/octokit/octokit.rb/pull/1256 to be able to make better specs like the one I tried...

This is a great idea. We had some surprises when we wanted to turn one verbose mode. We ended nearly providing again all the entrypoint commands to our helm chart.

Hello @dannyrife I took a look at your issue but there is two comments in specs that question myself. I am wondering if it was intended. https://github.com/DataDog/dd-trace-rb/blob/a6f2af005202ba806e52448c86bf2e28c37f04e9/spec/datadog/tracing/contrib/rails/database_spec.rb#L85 and https://github.com/DataDog/dd-trace-rb/blob/a6f2af005202ba806e52448c86bf2e28c37f04e9/spec/datadog/tracing/contrib/rails/database_spec.rb#L113 But...

Hello @sinoridha By any chance did you try to specify ```ruby sampler = Datadog::Tracing::Sampling::RateSampler.new(0.5) Datadog.configure do |c| c.tracing.sampler = sampler # set sampling rate c.tracing.instrument :rails, { service_name: 'web' }...

Hello @ryush00 🤗 Thanks for the detailed feature request. I started looking into that. Thanks for the links too. I love the very complet implementation made in sentry-ruby with various...

I [started](https://github.com/DataDog/dd-trace-rb/compare/master...benoittgt:dd-trace-rb:3068-excluded-exceptions-class) to work on this, but before going further. I think we need to hear what would be wanted from dd-trace-rb maintainers. For example, we could ignore some exceptions...

What need to be done?

The same can be done for rake tasks with RSpec. ```vim let g:rails_projections = { \ 'lib/tasks/*.rake': { \ 'alternate': 'spec/lib/tasks/{}_spec.rb' \ }, \ 'spec/lib/tasks/*_spec.rb': { \ 'alternate': 'lib/tasks/{}.rake' \...

That's an old issue. But does someone succeed with this ?