Bennet Bo Fenner

Results 104 comments of Bennet Bo Fenner

> Could it have to do with preview tabs anyhow @bennetbo ? Have not tested this, but preview tabs is only on nightly right now, so it shouldn't

It seems like this is actually expected behavior, although I am not sure if this is the "best" behavior. There are multiple places where you can observe this, e.g. when...

And here is what it looks like when both the channel notes were changed and the chat contains new messages: ![image](https://github.com/zed-industries/zed/assets/53836821/2d55a916-2f6e-4d83-9b6a-9af6ba8acfb3) Ideally the greenish point should be aligned with the...

> When we implemented this new indicator the choice of not making unread chat messages cause the indicator to appear was an intentional one. > > Chat can be pretty...

> Oh hellllll yes! Haha so my assumption was correct that you were the one that mentioned something about wanting this feature in one of the first fireside hacks

> Is it possible to have a way to _not_ accept the suggestion? > > I could think of cases where you might want to type :something: without it being...

> > > Is it possible to have a way to _not_ accept the suggestion? > > > I could think of cases where you might want to type :something:...

> @bennetbo The code here seems fine, but let's address some of the feedback above: > > * We should only trigger with a space before the `:` to avoid...

> @bennetbo I suggest we de-scope doing this in buffers completely for now. As the 90% use-case is in the chat, but the 90%-complexity is making it work with buffers,...

Not sure why, but the actual rust docs do not specify an example, you can see it [here](https://doc.rust-lang.org/std/primitive.i32.html#method.checked_abs). It works perfectly fine for `i32::wrapping_rem(...)`, which actually has an example: ![image](https://github.com/zed-industries/zed/assets/53836821/64898fe7-e1dd-4439-8b4e-db8b230a74a0)