Bennet Bo Fenner

Results 104 comments of Bennet Bo Fenner

@SomeoneToIgnore looks like `pulldown_cmark` handles the parsing differently then GitHub. Take a look at this example: #### Nested Italic ``` Text: **as*teri*sks** Parser output: Start(Paragraph) Start(Strong) Text(Borrowed("as")) Start(Emphasis) Text(Borrowed("teri")) End(Emphasis)...

Looks like it was fixed in the 0.10.x version of pulldown-mark. I'll try to upgrade the dependency

Here is what it looks like now: ![image](https://github.com/zed-industries/zed/assets/53836821/d3804214-0c6a-48a8-a02d-c5e09fdb817e) I cannot spot a difference to the GitHub one, other than the line breaks at the last few lines (which is not...

Did some digging, it's indeed related to weak handles. The relevant code is here: https://github.com/bennetbo/zed/blob/b5b872656bb92d989043e388f9907ee582c99dea/crates/project/src/project.rs#L7079 As the worktree is neither visible nor shared via collab it's treated as a weak...

Are you sure you're only registering your custom font file only once? I suspect that you register the font for a second time when you generate a second page, so...

Hey, the order here should not be random, zed focuses the previously activated tab when closing the current one. So you probably activated the tabs in the following order 3...

> Hi. Is this already available in zed? @romu70 Looks like it is in Zed Preview v0.123.1 (and will probably land in stable next Wednesday) [Release notes & Download](https://zed.dev/releases/preview)

Thanks for the review, I cleaned up the example in the last commit. Still getting familiar with gpui 👍🏻

While working on this today, we thought about some questions that we need to answer before we can continue. ## Questions - How should we handle the max lines of...

> One thing I noticed, I'm not sure how to dismiss the reply action if I decide I dont want to do a reply after all. I think `esc` should...