Ben Ilegbodu

Results 31 comments of Ben Ilegbodu
trafficstars

FYI - This doesn't actually work yet. 😄 What it does at the moment is add a helper that will return an object representation of the evaluated prop definitions for...

So I've spent a few days trying to figure this out. 😅 The problem is a change in `css-loader` from [this PR](https://github.com/webpack-contrib/css-loader/pull/1121/files#diff-3274f1a37032fb0ae4e2823def0007c634e869ae0dfc304ff6a12c36513c3a52R64). I've opened an issue here: https://github.com/webpack-contrib/css-loader/issues/1214 The tl;dr...

> Good job @benmvp , though it was figured out a while ago: [webpack-contrib/css-loader#1152](https://github.com/webpack-contrib/css-loader/issues/1152) and in the beginning of thread you have a link to my fork of the package...

Yeah, I saw that it takes a string or a function, so that's a nice fix! 👏

@birdofpreyru - I've got a PR open (https://github.com/css-modules/generic-names/pull/10) in `generic-names` to update to match `css-loader`. With it merged and released, it should make fixing the bug here in `babel-plugin-react-css-modules` as...

Two year old issue, but I'll jump in anyway. I was gonna create a separate issue, but this seems relevant. I wanted to ask if you ever considered moving away...

Yeah I think it's wise to keep Handlebars as a default. In trying to get passed Handlebars' limitations a did a lot of code spelunking in `plop` & `node-plop`, so...

Yep the `setTemplateRenderer` was what I was thinking as well. Nice! What's the advantage of having Handlebars process after the lifecycle hook? I'm not seeing the use-case where you'd want...

Good point. We don't want it as easy as possible for folks to migrate over. Having it as a config property on `setGenerator()` means you could still have your existing...