Ben McGarry

Results 36 comments of Ben McGarry

I cannot repo this on old Reddit FF 75 with RES enabled all at default. I see exactly the same as @geo1088 does in 74. ![image](https://user-images.githubusercontent.com/9434920/78248870-545dfd00-74e5-11ea-87e2-9699e3e97240.png) Can you please provide...

Do you mean an additional prompt at extension load? It does look like it will prompt a warning at first run. The API not being available breaks in settings as...

Playing around with this, Chrome does require main permissions and the below trigger fires when the API is called. Not before. ![image](https://user-images.githubusercontent.com/9434920/111924636-7b6a6180-8a9d-11eb-8a24-65190bed0bdf.png) Firefox triggers this when the API is called:...

I ran the extension unpacked without the geolocation API, then rebuilt with the perm and updated in Chrome. Extension page showed the geolocation permission but I was not re-prompted. However...

With chrome not allowing this as an optional permission do we have a choice with it? It looks like from the original PR the API was never put in so...

We will end up wasting time trying to get polyfills in when a limited amount of us can actually test this. My opinion right now is to hold off until...

@larsjohnsen Realistically, how much polyfill do you think would be required? Like would it be possible to polyfill with a separate js loaded in to prevent heavy code change?

The version of RES you are testing is **extremely** old. v5.2.2 was released in December 2016 and is no longer a real representation of the RES code base as its...

It looks like AdGuard for Mac is an actual OSX application, which apple allow you to host and provide download. However for Safari extensions Apple strictly require them to only...

I'm reaching out to the devs to see what their views on this are as they gave us a iframe implementation. Please do not merge.