Ben McCann

Results 1525 comments of Ben McCann

Vite 4.1 will copy the server assets to `.sveltekit/output/server`, but we need to update the builder used by the adapter to copy the assets from both the server and client...

Yeah, looks like ESM only works in Chrome: https://caniuse.com/mdn-api_serviceworker_ecmascript_modules

@meticoeus can you share a project that reproduces this with graphql? The repo in the original issue description has been deleted

Thank you for that! I filed a bug upstream: https://github.com/vitejs/vite/issues/15379

will close this with https://github.com/sveltejs/kit/pull/11129 as a workaround

just FYI, we ended up swapping out your workaround for another one: https://github.com/sveltejs/kit/pull/11400

I talked to @pzerelles, the author of https://github.com/JonasKruckenberg/imagetools/pull/400, and he clarified that the issue is that Vite assets treats everything relative to Vite's basepath and not relative from where the...

This may be implemented in Vite 4.2: https://github.com/vitejs/vite/blob/v4.2.0-beta.0/packages/vite/CHANGELOG.md#420-beta0-2023-02-27

Closing as this can't be replicated and there was no response to any of the questions

@till it would seem that SvelteKit always sets base to `./` when building the client: https://github.com/sveltejs/kit/blob/cad0389e5f5f6d407e1c48f45d84c28c744d73aa/packages/kit/src/exports/vite/index.js#L431 Is there anything you notice being different in the output between a normal Vite...