Ben McCann

Results 1663 comments of Ben McCann

I agree. I'm suggesting that the example in the documentation may not actually be working and needs to be updated

I keep getting scores in the 60s. Vue scores worse than almost all other frameworks, but I'm not sure why

@NekR any chance you could take a look at this? thanks!

There's a PR for this issue: https://github.com/netlify/cli/pull/4141

SvelteKit deploys ESM-only on all platforms except Netlify. The lack of ESM support on Netlify is a continual pain point because SvelteKit and Vite need to bundle to CJS just...

looks like this one will need a rebase I don't know is it weird to have a variable like `regex_starts_with_Export` and maybe it should be a lowercase "e" instead?

I wonder if the benchmark would give different results after @ivanhofer's change: https://github.com/sveltejs/svelte/pull/7716

wow, that's a pretty nice speedup! I didn't look super closely at the test, but I wasn't sure exactly what it was testing or how it worked at first glance....

hey @mhatvan just fyi, I primarily work on Sapper, so you'd probably have to ask someone else about issues in svelte core since I don't know enough about it yet

I didn't look super closely, but it generally seems reasonable to me. The one thing that jumped out to me though is that [the code from `eslint-plugin-jsx-a11y`](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/src/rules/click-events-have-key-events.js) encapsulates its logic...