benma

Results 434 comments of benma

If I interpret [this](https://gitlab.com/fdroid/rfp/-/issues/2393#note_1321891172) correctly, fdroid would reject this because of the bundled BitBox02 firmware. If that is correct, we can't proceed here, right?

> But then, I see no APK at the releases which I could pick. If you are talking about BitBoxApp v4.36.1: that was a hotfix to the Windows release. [4.36.0...

> Do you need anything from me before continuing with the merge? As far as I understand we can't get into fdroid because of the firmware binary that is still...

> > I guess it does not make sense to merge before there is a clear path to inclusion/publishing? > > Depends on what sense you're looking for wink First,...

> > What is that private repository and how does it relate to F-Droid? > > OK, full disclosure: it's my repo – and I'm one of the F-Droid maintainers....

> For the full inclusion criteria of my repo, you can [find them here](https://gitlab.com/IzzyOnDroid/repo/#what-are-the-requirements-an-app-must-meet-to-be-included-with-the-repo). And yes, with the size question solved (and this PR merged), your app would meet those...

This is a nice change but it destroys allowing requests to third parties based on the current url (e.g. can load moonpay when on buy page, etc.), because with the...

> Failed to open device. Please try again. This indicates that another app is connected to the BitBox02, like the BitBoxApp or some other web wallet. Please make sure only...

I need to test this on bitbox01 (bootloader, firmware) and bitbox02 (bootloader, firmware) on all supported platforms.

This was missing a CHANGELOG entry, see also: https://github.com/digitalbitbox/bitbox-wallet-app/issues/2613