bitbox-wallet-app icon indicating copy to clipboard operation
bitbox-wallet-app copied to clipboard

frontend/account-summary: add coins total balance

Open strmci opened this issue 1 year ago • 2 comments

Before this update, the account summary didn't show total coin balances, especially when managing multiple wallets with the watch-only feature. This commit addresses that by adding a new coin balances table below the chart. It appears only when there are multiple wallets in the portfolio.

strmci avatar Feb 23 '24 13:02 strmci

@thisconnect updated, PTAL

strmci avatar Feb 27 '24 09:02 strmci

I've only tested with with a BitBox and a remembered wallet. Looks good. Maybe a bit unrelated but when I unplug the device, the chart sometimes looks funny and goes into a bit a weird state.

PR https://github.com/digitalbitbox/bitbox-wallet-app/pull/2635 should properly mount and unmount the chart if there are changes. So I think we should merge https://github.com/digitalbitbox/bitbox-wallet-app/pull/2635 first.

thisconnect avatar Mar 18 '24 17:03 thisconnect

@strmci is this the same backend code that got removed in an earlier commit?

thisconnect avatar Mar 19 '24 18:03 thisconnect

@strmci please rebase

thisconnect avatar Mar 20 '24 07:03 thisconnect

@strmci is this the same backend code that got removed in an earlier commit?

yes, it is the same code

strmci avatar Mar 20 '24 07:03 strmci

yes, it is the same code

could you add the commit hash where it got removed in your commit message, so it is easier to review?

thisconnect avatar Mar 20 '24 07:03 thisconnect

@strmci please rebase

could you add the commit hash where it got removed in your commit message, so it is easier to review?

@thisconnect rebased and commit hash added, PTAL

strmci avatar Mar 20 '24 07:03 strmci

This was missing a CHANGELOG entry, see also: https://github.com/digitalbitbox/bitbox-wallet-app/issues/2613

benma avatar Apr 25 '24 09:04 benma