Ben Reinhart

Results 15 comments of Ben Reinhart

Hmm, interesting. What version of dbmate are you using? It is supposed to fail in that case. The [regular expression](https://github.com/amacneil/dbmate/blob/master/pkg/dbmate/migrations.go#L44) used to parse the `-- migrate:up` line should not match...

Ohh I just realized this is for the `-- migrate:down` block. The [regular expression](https://github.com/amacneil/dbmate/blob/master/pkg/dbmate/migrations.go#L45) for down expects the same strictness, but since it's allowed to be omitted, it's just being...

@etr2460 I agree that consistency here is desired. I think we wanted to leave the existing cache _values_ as they are, but as for the logic that generates the cache...

I do not have a road map. Unfortunately, I am not currently working in react native regularly, so this project is not a priority for me. That being said, I...

Hey sorry I'm taking so long. Will try to look at this tonight.

Hey Kelong, Thanks for trying out the lib! It doesn't work because the policy is generated differently for the `PutObject` calls given we're following the [Browser Based Uploads](http://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-post-example.html) approach. However,...

I unfortunately haven't been able to get to it yet. I'll try to take another pass this weekend if I can.

Unfortunately, I am not sure. Did you try to use this library and pass the base64 data and see if that worked?

Cool, thanks for this! Few things before I would consider merging this: 1. My personal style would be to have a simpler method signature, so I wouldn't use the default...

@MrHubble sadly, I think you're right. I originally started this because I did not want native dependencies and I wanted a simple interface. At the time at least, the aws...