Ben Lambert

Results 624 comments of Ben Lambert

Hey, so we have Google Analytics support built in which will give you page views. You can enable that by adding the tracking data to this config, https://github.com/backstage/backstage/blob/e9bcb7b446425276b6545616cff726be12afd0dd/app-config.yaml#L4 We don't...

I think this is because of how the state is set. It's just spread into the existing state, rather than replacing the existing state for each step. So if it's...

I think this is the warning that you will need to fix: https://github.com/backstage/backstage/pull/12991/files#diff-5fe272b69ff07c2c29f6a147e763a43b045bcd74550c42b0b412013eca0f86ebR439-R441 It's basically because of the `@property` tag that you're using I believe. You can document it using...

Gonna slap an `after-vacations` label on this so that we can pick it up when all @backstage/maintainers are back and we can go through this together if that's ok @punkle

hmm some of them are legit failures though if you take a look at the `files changed` tab, we can probably ignore the others I think.

Hmm @punkle those are weird, not seen those before. Do they look like valid errors too?

Yep - let me fix up those errors, these might have been to do with lerna or something that means that these didn't run in CI and I missed them...

Wow - I'm liking where this is going! As for the tests, that's an interesting question. I wonder if it would make sense to move some of these tests to...

Hey! Sorry for the delay in getting back to you, yep OK, this looks like a decent way to go. Looks like it could be a good baseline for more...

I think you can create your own like you mentioned for the `describeIfGithubActions` or something like you mentioned earlier, rather than changing the one that already exists.