Ben Lambert

Results 646 comments of Ben Lambert

@Rugvip the bump of Vite to v5 moves rollup to v4, which now leads to this error: ``` node_modules/vite/dist/node/index.d.ts:5:41 - error TS2307: Cannot find module 'rollup/parseAst' or its corresponding type...

@mbenson im out on holiday at the minute, but I'll reopen this before I forget the ping. I like the direction of using `ajv-errors` if we can, and using their...

Im fact I can't reopen it for some reason? 😅

Re-opening as this is something that we want to support and be able to provide some CLI or interface for doing this easier.

@Rugvip this looks like it needs a rebase 😅

@rmartine-ias thanks for the great issue report! Hmm its unfortunate that it's hard coded to disable the throttling, I wonder if we should open up the ability to configure that...

@rmartine-ias sorry I seemed to have missed your last ping on this message. Great work digging into this and coming up with some suggestions as to what we want to...

@pedronastasi I'm not sure that it's a memory leak, as mentioned earlier in this issue there's a lot of requests that are made when creating PR's against a GH repo...

I'm still not convinced that this is a memory leak though, the heap size is stable, which is the amount of memory actually being used after GC and everything else...

@pedronastasi what do you have set for `--max-old-space-size`? I'm wondering if it's just not been claimed back by GC yet? It's possible that it could be use of `Buffer` or...