Ben Lambert

Results 646 comments of Ben Lambert

Hey @tylerd-canva! Sorry it's taken a while to get round to this, been catching up coming back from the holidays and been a little ill so working through the list....

Think that there's currently two usages of `ajv` in the `backstage/backstage` monorepo. I think that they're `swagger` and `react-jsonschema-form` for the scaffolder. There's already been some exploration into replacing `ajv`...

I'm not super familiar with OneLogin, so this is a bit of a shot in the dark, but `offline` scope might be necessary for refreshes? Have you tried adding that...

@akira-personio the docs that you linked to mention `offline_access` scope. That's the exact scope that I think is going to help with refresh tokens. Do you provide that scope?

Hmm looks like `offline_access` is in the defualt list of scopes for `OneLogin` https://github.com/backstage/backstage/blob/ef729bc30cb3c3726fded9b5d7c144b9eaaad3cf/packages/core-app-api/src/apis/implementations/auth/onelogin/OneLoginAuth.ts#L79

@akira-personio hmm, well this is interesting. Looking at the diff for the two versions theres not really much thats changed in the `auth-backend` apart from the Microsoft auth provider: https://github.com/backstage/backstage/compare/v1.22.2...v1.19.3

Hmm ok - I'm gonna bring in @Rugvip to this too, he might have some ideas, but it's good that you've found something that at least works so we can...

Closing as fixed :tada: thanks @manuelfalcon! :pray:

Hey :wave: is there any chance that we can get this change rolled forward and undone? Granted it's a small breaking change, but still breaking either way and looks like...

Closing as resolved in #15953