Ben Lambert comments

Results 630 comments of


                                            Ben Lambert

Create a new action to publish on gitea

@cmoulliard I think you will need to rebase this branch against the latest mainline branch to get `Verify Docs Quality` to pass.

Create a new action to publish on gitea

@cmoulliard for things that are part of the public API for the package, like things that are exported for use in other packages will need to have a tsdoc annotation...

[RFC] Backstage notification API (frontend)

Don't think there's much movement yet, and there's still some architectural questions to be answered I think. But one thing to note is that I think with the introduction of...

DatabaseManager' is not assignable to type v1.21.1

Looks like you have duplicates of `backend-common` in `yarn.lock` Could you try using the `yarn backstage-cli versions:bump` command, or by making sure that the versions are aligned by using `yarn...

Updated to use default import

Thanks @awanlin!

new backend system: events service

Added some more people to this for :eyes:

Thomas1001101 plugin scaffolder backend module gitlab part2

Hey @thomastroschke! I think you'll need to fix up the DCO check and make sure that your commits are signed off properly. You'll also need to run `yarn install` and...

Thomas1001101 plugin scaffolder backend module gitlab part2

@thomastroschke no probs! Thanks! :pray:

🐛 Bug Report: fetch:plain scaffolder action does not preserve file structure when fetching from an S3 URL

Hmm yeah this looks wrong. I think that there could be an issue with the `readTree` method on the `AWSS3URLReader` and it not creating the correct paths when reading with...

🐛 Bug Report: fetch:plain scaffolder action does not preserve file structure when fetching from an S3 URL

yep - think `basename` is wrong here, great find! @mttwise do you wanna raise a PR for this? Looks like this has been a longstanding bug, but we just don't...