Ben Newman

Results 224 comments of Ben Newman

@pastelsky I hear you, but giving a useful warning is difficult here, because you don't _need_ `possibleTypes` if all your fragment type conditions are concrete type names (like `CompatibleAtlassianDataCenterProduct` instead...

@ab-pm Here's a comment from the source code that attempts to rationalize this decision: https://github.com/apollographql/apollo-client/blob/971ecfcc20be748084c4b769c2a7518845c3919f/src/cache/inmemory/policies.ts#L813-L826 In short, `readField('id')` is ambiguous in `merge` functions, whereas there's only one thing it could...

Thanks for trying the betas @aub (and @dylanwulf and possibly others in this thread)! Those time windows would be shorter if more folks gave feedback (positive or negative) on the...

Please note that it's not possible to go back in time whenever `addTypePolicies` is called, and rewrite the cache as if those type policies had been in place the whole...

Implementation-wise, there's a private [`policies.getTypePolicy(typename: string)`](https://github.com/apollographql/apollo-client/blob/bc14e870f929e96fe3b75cc1f32b86935477cf0c/src/cache/inmemory/policies.ts#L506) method that gets called whenever the cache needs to look up the policy for a given `typename` string. Although you could maybe get away...

It's not currently guaranteed to fail, but I'm in favor of making `addTypePolicies` fail in that case.

The `web.browser.legacy` build is running in a separate process (the parent/build process) from the server startup code, so I believe those two chunks of work are racing in parallel, without...

One quick follow-up observation: if the legacy build is still running, and you make _another_ change, the build system won't pick that change up and start rebuilding until the previous...

@KoenLav Were you not using the 1.8 betas? I'm confused about what past you're referring to (compared to "now"), since I can't imagine that 1.8 is worse than 1.7. I'm...

> If I hack the delayed build to take a long time (30 seconds) I can definitely see changes (or manually reload the app) long before the legacy bundle finishes...