Ben Newman
Ben Newman
What if the `async_hooks` stack was stored in thread local storage by Node/V8, so that there would automatically be separate stacks for each thread/fiber? Then you wouldn't have to save...
I understand your skepticism, but I think this idea is important to make `async_hooks` thread-aware in a general sense, so it wouldn't be just for the sake of fibers. Also,...
Another idea: if Node was willing to expose an API for swapping out the whole async ID stack at once, rather than popping/pushing every item, that would help node-fibers implement...
@AndreasMadsen Without careful saving/restoring, the async ID stack can get corrupted if used from multiple threads (not necessarily fibers), even if the threads are fully cooperative and always lock the...
> There's exactly 3 TLS keys I need to discover and then I manually modify those 3 keys after every context change. So if we just made this structure thread-local...
This behavior is expected, but it's worth noting that a better system would have the following properties: * Every `async` function acquires a new `Fiber` in which to do its...
This package uses pure CommonJS, which allows circular `require`s, and it works in Node. I also thought Rollup was only for ES2015 `import` and `export`? What's the error?
@danielo515 I think `JSXElement` should be a subtype of `Expression`? https://github.com/benjamn/ast-types/blob/b99f9b3ef5000631c06d71d91ee7aa341c9a81fb/gen/namedTypes.ts#L666 In your case, both `JSXElement.check(arrowFunExpr.body)` and `Expression.check(arrowFunExpr.body)` should return `true`, so I think the `body` type might be okay?
Why not just `bash test/run.sh` without the `-c`?
Also, I think I've fixed the cause of the test failures on `master`, so please feel free to rebase this PR.