Ben Newman
Ben Newman
Can you give an example of what you'd like to be able to do?
Thanks for this! I realize this is a work in progress, so I'm definitely thinking about it as an experiment that may have to be subdivided and/or expanded in different...
I'm not really comfortable forcing a post-order traversal, and I don't think it's enough to provide pre-order traversal as an alternative, since it's useful in many cases to be able...
The `needsParens` method is used pretty heavily by https://github.com/benjamn/recast, and it's a good example of an AST utility method that requires knowledge of ancestor nodes. In other words, thanks for...
After looking at the code, I like `StackPath` so much that I'd actually prefer to reimplement `NodePath` using a stack, rather than having two different `Path` subtypes. As a bonus,...
This is really promising and makes a ton of sense (of course there should be a `NodeVisitor` and not just a `PathVisitor`… the opportunity to speed up simple transforms is...
I'm wondering about the appropriate interface for exposing these two different kinds of visitors, and it occurs to me that we could just use `PathVisitor` if you pass a `NodePath`...
Can you audit the other places in this file where `n.CallExpression.check` is used and decide if those sites need a `n.NewExpression.check` too? If you think it helps, you can also...
Sorry for the delay on these issues/PRs! Is there always a `/tmp/` directory on Windows? Maybe we should use [`os.tmpdir()`](https://nodejs.org/api/os.html#os_os_tmpdir) for portability?