Benjamin Romano

Results 34 comments of Benjamin Romano

Running into this as well for `pyarrow`. Here is example of what inputs look like: ``` runfiles/py_deps_pypi__pyarrow/pyarrow/tensor.pxi=external/py_deps_pypi__pyarrow/pyarrow/tensor.pxi runfiles/py_deps_pypi__pyarrow/pyarrow/tensorflow/plasma_op.cc=external/py_deps_pypi__pyarrow/pyarrow/tensorflow/plasma_op.cc runfiles/py_deps_pypi__pyarrow/pyarrow/tests/bound_function_visit_strings.pyx=external/py_deps_pypi__pyarrow/pyarrow/tests/bound_function_visit_strings.pyx runfiles/py_deps_pypi__pyarrow/pyarrow/tests/data/feather/v0.17.0.version=2-compression=lz4.feather=external/py_deps_pypi__pyarrow/pyarrow/tests/data/feather/v0.17.0.version=2-compression=lz4.feather runfiles/py_deps_pypi__pyarrow/pyarrow/tests/data/orc/README.md=external/py_deps_pypi__pyarrow/pyarrow/tests/data/orc/README.md ``` The `compression=lz4.feather` is the offending line.

To add onto that note, the executable zip generated by `--build_python_zip` after I applied my patch has terrible cold start performance due to Bazel's implementation not caching the extracted files...

Hi @aioutecism, I had some free time and I looked into the testing framework. Check it out here #96.

@aioutecism have you had a chance to look over the testing framework? If you are too busy atm, I'd be willing to join as a contributor to help with progress.

:+1: This would be useful in the context of my feature request as well. The solution I used in my fork adds quite a bit of overhead as an invocation...

@ymakhno bumping this old issue. I worked around this by forking bundletool, but it would be nice to have this built-in instead. If this general approach makes sense I could...

Is this something we are comfortable with adding support for? @jin