Benjamin Bræstrup Sayoc
Benjamin Bræstrup Sayoc
### Should be `elif` https://github.com/FreeCAD/FreeCAD/blob/ea60b2ec1ec42c3887e58cd9ecc911c36f8690cb/src/Mod/Path/PathScripts/PostUtilsArguments.py#L609 https://github.com/FreeCAD/FreeCAD/blob/ea60b2ec1ec42c3887e58cd9ecc911c36f8690cb/src/Mod/Path/PathScripts/PostUtilsArguments.py#L634 https://github.com/FreeCAD/FreeCAD/blob/ea60b2ec1ec42c3887e58cd9ecc911c36f8690cb/src/Mod/Path/PathScripts/PostUtilsParse.py#L457 https://github.com/FreeCAD/FreeCAD/blob/ea60b2ec1ec42c3887e58cd9ecc911c36f8690cb/src/Mod/Path/PathScripts/PostUtilsParse.py#L460 ### Avoid nesting https://github.com/FreeCAD/FreeCAD/blob/ea60b2ec1ec42c3887e58cd9ecc911c36f8690cb/src/Mod/Path/PathScripts/PostUtilsExport.py#L167-L172 https://github.com/FreeCAD/FreeCAD/blob/ea60b2ec1ec42c3887e58cd9ecc911c36f8690cb/src/Mod/Path/PathScripts/PostUtilsParse.py#L296-L297 https://github.com/FreeCAD/FreeCAD/blob/ea60b2ec1ec42c3887e58cd9ecc911c36f8690cb/src/Mod/Path/PathScripts/PostUtilsParse.py#L301-L302 https://github.com/FreeCAD/FreeCAD/blob/ea60b2ec1ec42c3887e58cd9ecc911c36f8690cb/src/Mod/Path/PathScripts/PostUtilsParse.py#L311-L312 https://github.com/FreeCAD/FreeCAD/blob/ea60b2ec1ec42c3887e58cd9ecc911c36f8690cb/src/Mod/Path/PathScripts/PostUtilsParse.py#L460 https://github.com/FreeCAD/FreeCAD/blob/ea60b2ec1ec42c3887e58cd9ecc911c36f8690cb/src/Mod/Path/PathScripts/PostUtilsParse.py#L466 https://github.com/FreeCAD/FreeCAD/blob/ea60b2ec1ec42c3887e58cd9ecc911c36f8690cb/src/Mod/Path/PathScripts/PostUtilsParse.py#L488 ### Avoid unnecessary use of variables (just return without saving to variable...
@LarryWoestman, above only if you want extra extra bonus points
@LarryWoestman Get this to review and get it merged. It shouldn't grow any bigger... already now is too big. It will be impossible to review all the way through
@LarryWoestman You will have to merge the different commits. All typo fixes should be in 1 commit. All f-string fixes should be in one commit. All commits making tests should...
This PR is assuming that I understood https://forum.freecadweb.org/viewtopic.php?f=10&t=70796 correctly. > I could be wrong, but I don't think PreCompiled.h is supposed to appear in *.h files, only *.cpp. If I...
Ready for review @WandererFan
@WandererFan Let me know what needs to be done to move forward with this
https://github.com/FreeCAD/FreeCAD/blob/158444701fac93abd3092c4c654384e6c79bc523/src/Mod/TechDraw/App/DrawViewPart.cpp#L627-L628 ``` if ((*it)->getTypeId().isDerivedFrom(DrawHatch::getClassTypeId()) && !(*it)->isRemoving()) { ``` https://github.com/FreeCAD/FreeCAD/blob/158444701fac93abd3092c4c654384e6c79bc523/src/Mod/TechDraw/App/DrawViewPart.cpp#L641 ``` if ((*it)->getTypeId().isDerivedFrom(DrawGeomHatch::getClassTypeId()) && !(*it)->isRemoving()) { ``` https://github.com/FreeCAD/FreeCAD/blob/158444701fac93abd3092c4c654384e6c79bc523/src/Mod/TechDraw/App/DrawViewPart.cpp#L803 ``` return bbx.MaxX - bbx.MinX; ``` https://github.com/FreeCAD/FreeCAD/blob/158444701fac93abd3092c4c654384e6c79bc523/src/Mod/TechDraw/App/DrawViewPart.cpp#L809 ``` return bbx.MaxX - bbx.MinX; ```...
To me it looks like it was implemented in https://github.com/FreeCAD/FreeCAD/commit/380386851e2349e87665a60464b0e7ba7d4c1047. Could you confirm and close, @luzpaz?
This is an issue on Ubuntu 22.04 too. Seeing 5+ cpptools-srv allocating huge amounts of memory.