benito

Results 22 comments of benito

would be nice to get this either changed to 308 or as an option 👍 (small bump)

Thanks for the enthusiasm :) my goal is to create a chart to monitor request duration for now, found that tusd doesn't have the instrumentation needed for this kind of...

Very good question indeed the duration of each request will not provide meaningful information about the process, nevertheless the same duration instrumentation could be applied to: **upload duration** between [start](https://github.com/tus/tusd/blob/a51f5994bba6c22369023de55acf15071ee3c69b/unrouted_handler.go#L292)...

``` histogram := prometheus.NewHistogramVec(prometheus.HistogramOpts{ Name: "process_duration_seconds", Help: "Time taken to process a file", }, []string{"action"}) ``` ``` start := time.Now() // Process here // how do we keep the start...

start time in the metadata is a much better idea :)

I was able to implement authentication using the http hook: ``` tusd -hooks-http="http://localhost:8081/tusd/hook" ``` ```golang server.Router.HandleFunc("/tusd/hook", func(w http.ResponseWriter, r *http.Request) { // https://github.com/tus/tusd/blob/master/docs/hooks.md#usage // log.Println("HOOK: ", r.Header.Get("hook-name")) hookName := r.Header.Get("hook-name")...

> I am not sure what you mean by this Sorry I meant read access limit, a way to prevent unwanted file reads

Hello! Yes this PR is trying to address the lack of content access control > a proper authentication system using hooks where a hook is always invoked before a user...

rebased with master branch and some further changes: - call pre-get hook before getting file info so we don't return 404 without calling the hook - added pre-get to the...

> I think it's a bit weird if we have a system to check access before GET requests but not HEAD or PATCH requests. Agreed, I understand the need for...